Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auditor app crashes on initial device pairing #64

Closed
Jawshy opened this issue Jan 24, 2020 · 11 comments
Closed

Auditor app crashes on initial device pairing #64

Jawshy opened this issue Jan 24, 2020 · 11 comments
Labels
bug Something isn't working

Comments

@Jawshy
Copy link

Jawshy commented Jan 24, 2020

The Auditor app keeps stopping when attempting to perform the initial pairing between a phone and tablet.

Auditor: Google Pixel 3a XL [Model: G020B]
Auditee: Galaxy Tab A 10.1 2019 (Wi-Fi) [Model: SM-T510]

Both devices are running Auditor version 17.

Steps to reproduce issue:

  1. Launch Auditor on both devices.
  2. Tap 'auditor (device performing verification)' on the Pixel.
  3. Tap 'auditee (device being verified)' on the Tab A.
  4. Scan QR code shown on the other device.
  5. The app crashes.

No issues when auditor and auditee are switched; pairing and verification are successful.

Please let me know if additional information is needed.

@thestinger
Copy link
Member

Can you trigger the crash and then go into developer options and use the take bug report feature to send a bug report to contact@attestation.app? Note that the bug report zips may contain some sensitive data if crash dumps or logs contain it.

Alternatively, you could use ADB to run adb logcat on an attached + whitelisted host computer and then trigger the crash.

It's likely that a minor mistake was made in the metadata added to support this tablet which will need to be corrected.

@thestinger thestinger added the bug Something isn't working label Jan 24, 2020
@Jawshy
Copy link
Author

Jawshy commented Jan 25, 2020

Sent 📬

@thestinger
Copy link
Member

@Jawshy Can you check if this is still a problem and send another bug report?

@Jawshy
Copy link
Author

Jawshy commented Apr 8, 2020

The app still crashes on the tablet. I've sent a bug report to contact@attestation.app

@thestinger
Copy link
Member

@Jawshy I think ce8c0f4 will fix the issue. I can make a test release for you to try on the Auditee.

@thestinger
Copy link
Member

It might be better to just make a normal release due to how Auditor releases impact attestation.

@thestinger
Copy link
Member

Adjusted this to a0cc37c to avoid weakening the check on other devices.

@thestinger
Copy link
Member

This will be fixed by the next release when I finally find the time to put that together...

@thestinger
Copy link
Member

@Jawshy This is FINALLY released in version 18. Sorry it took so long.

@Jawshy
Copy link
Author

Jawshy commented Jun 26, 2020

I updated Auditor to version 18 on both devices and tried verifying the tablet again. The app didn't crash, but the verification failed on the first attempt. Upon clearing the auditee parings, the initial pairing was successful on the second attempt. Cheers.

@thestinger
Copy link
Member

It probably failed due to the previous failed pairing. If the pairing is incomplete, the device being audited doesn't actually know that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants