add ProgressBar with new Toolbar to show loading #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inthewaves
force-pushed
the
progress-bar-pr
branch
from
c6d1447
to
50b9caa
Compare
inthewaves
changed the title
inthewaves
force-pushed
the
progress-bar-pr
branch
from
50b9caa
to
f4a3606
Compare
inthewaves
changed the title
inthewaves
force-pushed
the
progress-bar-pr
branch
3 times, most recently
from
9c3f204
to
7df800d
Compare
A ProgressBar is displayed when a page is rendering; the ProgressBar is hidden after the page has been displayed to the screen. In order to make the ProgressBar show under the ActionBar, we use our own Toolbar integrated into the Activity's layout instead of the one provided by the system. (This also gives us a bit more control over styling.) The ProgressBar is set to indeterminate. Zooming in does not show the ProgressBar.
inthewaves
force-pushed
the
progress-bar-pr
branch
from
7df800d
to
05ab36c
Compare
|
Redid this at https://github.com/inthewaves/PdfViewer/tree/fragments-revamp-theme based on the Fragments branch, so I'll wait until Fragments are ready before opening a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On hold until #72 is looked at
A ProgressBar is displayed when a page is rendering; the ProgressBar is
hidden after the page has been displayed to the screen. In order to make
the ProgressBar show under the ActionBar, we use our own Toolbar
integrated into the Activity's layout instead of the one provided by the
system. (This also gives us a bit more control over styling.)
The ProgressBar is set to indeterminate. Zooming in does not show the
ProgressBar.
Closes #29