-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add additional disabling for AImageReader #52
Conversation
Signed-off-by: Renlord <me@renlord.com>
9e761a7
to
5b0df69
Compare
The referenced Bromite patch also disables hardware-accelerated decoding under some conditions, see the issue dicussion. Without that you will still get crashes on Android 10 arm64 (only for Adreno GPUs, according to an user). |
@csagan5 are you talking about this part of the patch? If so that could explain why I'm still seeing the crash even with this PR applied on blueline |
I was actually able to get HW acceleration to work on sargo and can no longer re-produce crashes. How I tested was:
No crashes so far. Still investigating what the actual problem is. I have a suspicion it might have to do with build environment, but still too early to tell.
|
@renlord what changed? a clean build / latest Chromium version? From your
This of course means nothing without comparing to a |
Protected is probably just marked unavailable due to it being GrapheneOS. |
I just tried again on blueline with a completely fresh build of both vanadium and graphene ( I'm building on an Arch Linux host. I'm going to try building on Ubuntu to test renlord's theory that it could be something with the build environment. |
Crashing Case
Fixed Case
|
@renlord thanks; please see my reply in bromite/bromite#445 |
Tested on Sargo -- the issue.
Closes GrapheneOS/os-issue-tracker#166.
Related:
bromite/bromite#445
https://github.com/bromite/bromite/blob/master/build/patches/Revert-Merge-to-M78-Enable-AImageReader-by-default.patch
https://bugs.chromium.org/p/chromium/issues/detail?id=977583&q=aimagereader&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified