Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate text layers to nodes #1155

Merged
merged 24 commits into from Apr 27, 2023
Merged

Migrate text layers to nodes #1155

merged 24 commits into from Apr 27, 2023

Conversation

0HyperCube
Copy link
Member

@0HyperCube 0HyperCube commented Apr 24, 2023 •
edited by Keavon

Closes #998, closes #1163, closes #768

  • Node impl
  • Properties
  • Preview
  • Font cache to graph
  • Fix transforms
  • Enter text tool on double click
  • Fix error when using path tool
  • Fix text sometimes not being rendered

Moved to a separate issue:

@0HyperCube 0HyperCube changed the title Text node wip Text node Apr 24, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 24, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e45c22
Status: ✅  Deploy successful!
Preview URL: https://65851f2c.graphite.pages.dev
Branch Preview URL: https://text-node-wip.graphite.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Apr 25, 2023 •
edited

✅ Deploy Preview ready!

Name Link
🔨 Latest commit d6481b9
🔍 Latest deploy log https://github.com/GraphiteEditor/Graphite/actions/runs/4815217644
😎 Deploy Preview Url https://ebb5bac7.graphite.pages.dev
🌳 Environment production

@0HyperCube 0HyperCube marked this pull request as ready for review April 25, 2023 19:34
@0HyperCube 0HyperCube linked an issue Apr 25, 2023 that may be closed by this pull request
Stop vector layers disappearing whilst dragging #1163
Closed
@Keavon
Copy link
Member

Keavon commented Apr 26, 2023 •
edited by 0HyperCube

A few issues I noticed while QA testing:

  • When reloading the page (to auto-save and load), the text appears as a 1x1 pixel node graph frame blue dashed line. Moving it (with G), for example, makes it update
  • Scrolling with the scroll wheel while editing text makes it follow the viewport rather than scrolling with the document (which works in master)
  • The properties entry for "Font" has "Style" below it which would be nice to have the extra spacers to fix the alignment; and I'd also say it's probably clearer to users if the "Style" label is removed entirely so it looks like the "Font" entry is just two lines for the family + style dropdowns
  • The "Font" entry described above has a green "expose" dot in its properties entry, but it's (I think correctly) gray in the graph when exposed
  • To avoid permanently "breaking" a piece of text which has been (attempted to be) modified by the Path tool, can you add a temporary special case to prevent that breaking modification until Vector Edit node #1162 is implemented?

I think that's everything (that I could find, at least)! This is awesome, can't wait to merge it— finally we're on the home stretch for full nodes!

@Keavon Keavon changed the title Text node Migrate text layers to a node Apr 26, 2023
@Keavon Keavon changed the title Migrate text layers to a node Migrate text layers to nodes Apr 26, 2023
@Keavon Keavon merged commit d6481b9 into master Apr 27, 2023
4 checks passed
@Keavon Keavon deleted the text-node-wip branch April 27, 2023 02:07
Keavon added a commit that referenced this pull request Jul 30, 2023
@0HyperCube @Keavon
Migrate text layers to nodes (#1155)
ef93f84 
* Initial work towards text to node

* Add the text generate node

* Implement live edit

* Fix merge error

* Cleanup text tool

* Implement text

* Fix transforms

* Fix broken image frame

* Double click to edit text

* Fix rendering text on load

* Moving whilst editing

* Better text properties

* Prevent changing vector when there is a Text node

* Push node api

* Use node fn macro

* Stable ids

* Image module as a seperate file

* Explain check for "Input Frame" node

* Code review

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueDoctor TrueDoctor TrueDoctor left review comments

@Keavon Keavon Keavon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@0HyperCube @Keavon @TrueDoctor