Fix dropdown keyboard movement bug

[elbertronnie]

Fixes a bug where the keyboard movements for Up and Down arrow in a Dropdown list do not behave properly.

This bug is part of code-todo-list channel in Discord: https://discord.com/channels/731730685944922173/881073965047636018/1111934349663805450

This bug happened because in many instances value parameter was not provided in MenuListEntry.

[Keavon]

!build

[github-actions]

📦 Build Complete for ac0766b
https://3e9afbc1.graphite.pages.dev

[elbertronnie]

This is mostly a temporary fix. A much more permanent fix would be to make value as the constructor instead of label. This way there will be less chances of forgetting it. Should I do this?

And should I do a similar thing with RadioEntryData if it is ever decided that Radiobuttons will also be controlled by keyboard in the future?

[0HyperCube]

Thanks for this fix.
I think making the value the constructor would be a good approach, possibly alongside the label. I can't see any use-cases where the value should be different from the label so perhaps we could merge them for the menu list entry struct?

For the RadioEntryData I think it is probably advantageous to have the value as a constructor argument as well as you suggested.

[elbertronnie]

I can't see any use-cases where the value should be different from the label so perhaps we could merge them for the menu list entry struct?

There may be cases in future where icon is used with no label. Merging them would break that. Radiobutton has this kind of use case already.

[Keavon]

Likewise, I believe localizations would result in a different value and label.

[Keavon]

This is mostly a temporary fix. A much more permanent fix would be to make value as the constructor instead of label. This way there will be less chances of forgetting it. Should I do this?

And should I do a similar thing with RadioEntryData if it is ever decided that Radiobuttons will also be controlled by keyboard in the future?

Yes please, to both!

[Keavon]

I'll temporarily set this to a draft again while awaiting that change you suggested @elbertronnie. Feel free to mark it as ready for review again when you're ready, and also please ping me so I notice.

[elbertronnie]

@Keavon I have made value a constructor in both MenuListEntry and RadioEntryData. I have also updated all definitions of value to be equal to what Debug trait prints where possible. In other cases it has been hard-coded with a lowercase string.

[Keavon]

Looks great, thank you for this!

[Keavon]

@elbertronnie I found a regression with the blend mode dropdown at the top of the Layers panel (next to the Opacity slider), since it seems to lack a label:

(shows the debug value for the first iteration of the Svelte template loop for the first entry)

Would you mind submitting a quick fix? (And if finding this makes you notice any other potentially forgotten lines of code, please double check those also if applicable.) Thanks!