Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression from #1630 for Layers panel blend modes missing labels #1649

Conversation

elbertronnie
Copy link
Collaborator

@elbertronnie elbertronnie commented Mar 5, 2024

This PR fixes a missed conversion in #1630
The bug is described in #1630 (comment)

And I have checked once again that every instance of MenuListEntry and RadioEntryData is converted in the codebase.

Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Keavon Keavon changed the title Quick fix for a missed conversion Fix regression from #1630 for Layers panel blend modes missing labels Mar 5, 2024
@Keavon Keavon force-pushed the quickfix-for-dropdown-keyboard-movement branch from d6fb4ef to 550b1dd Compare March 5, 2024 03:51
@Keavon Keavon enabled auto-merge (squash) March 5, 2024 04:07
@Keavon Keavon merged commit 2f44b15 into GraphiteEditor:master Mar 5, 2024
2 checks passed
@elbertronnie elbertronnie deleted the quickfix-for-dropdown-keyboard-movement branch March 15, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants