Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix untranslated login window #1015

Merged
1 commit merged into from
May 20, 2022

Conversation

4Benj
Copy link
Member

@4Benj 4Benj commented May 20, 2022

Description

My earlier pull request (#962) seemed to break the login window because I didn't realise that there were translation files hosted on the webstatic server. This is a potential fix. However, I am unable to test this due to not having an android device (which the bug seems to be primarily effecting.

NOTE: Only English files are provided, so in every region the login window will appear in English.

Issues fixed by this PR

#1005
#982

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@ghost ghost merged commit d59e14e into Grasscutters:development May 20, 2022
@4Benj 4Benj mentioned this pull request May 20, 2022
8 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant