Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanent fix for version.json stuff (fixes 4206 on some clients) #962

Merged
1 commit merged into from
May 17, 2022

Conversation

4Benj
Copy link
Member

@4Benj 4Benj commented May 17, 2022

Description

This is a more permanent solution to #935.

Please carefully read the Contributing note and Code of conduct before making any pull requests.
And, Do not make a pull request to merge into stable unless it is a hotfix. Use the development branch instead.

Issues fixed by this PR

Some clients experience a 4206 error. This was fixed with #935 (not in development branch) but it was more of a temporary solution.

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@ghost ghost merged commit c33ac71 into Grasscutters:development May 17, 2022
@vhcrack
Copy link

vhcrack commented May 17, 2022

oh my god thank you, you've saved me like a million headaches

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants