Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Payment Status and Payment Amount Conditional Logic options #1405

Closed
wants to merge 0 commits into from

Conversation

jakejackson1
Copy link
Member

@jakejackson1 jakejackson1 commented Aug 26, 2022

Description

This PR registers two new choices in the conditional logic selector:

  1. Payment Status
  2. Payment Amount

I've opted not to include additional entry meta like Entry ID, or Entry Date, at this stage as it requires additional work to support. This PR just focuses on the most important meta data.

TODO:

  • Check if conditional logic will pass as is, or if we need to hook into Gravity Forms and make some tweaks when the logic is being parsed
  • Write E2E test

Partially resolves #1404

Testing instructions

Screenshots

Checklist:

  • I've tested the code.
  • My code is easy to read, follow, and understand
  • My code follows the accessibility standards.
  • My code has proper inline documentation / docblocks.

Additional Comments

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #1405 (7aa5aed) into development (493b8d5) will increase coverage by 0.98%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##             development    #1405      +/-   ##
=================================================
+ Coverage          77.34%   78.32%   +0.98%     
- Complexity          2900     2902       +2     
=================================================
  Files                243      243              
  Lines              10107    10133      +26     
  Branches             370      370              
=================================================
+ Hits                7817     7937     +120     
+ Misses              2282     2188      -94     
  Partials               8        8              
Impacted Files Coverage Δ
src/Model/Model_Form_Settings.php 92.92% <100.00%> (+0.33%) ⬆️
src/View/html/PDF/core_template_styles.php 98.00% <0.00%> (ø)
src/View/View_PDF.php 79.87% <0.00%> (+0.12%) ⬆️
src/Helper/Fields/Field_Repeater.php 97.80% <0.00%> (+0.15%) ⬆️
src/Helper/Fields/Field_Address.php 86.00% <0.00%> (+2.00%) ⬆️
src/Helper/Fields/Field_Quiz.php 91.66% <0.00%> (+2.77%) ⬆️
src/Helper/Helper_Field_Container_Gf25.php 90.00% <0.00%> (+6.00%) ⬆️
src/Helper/Fields/Field_Shipping.php 92.30% <0.00%> (+26.92%) ⬆️
src/Helper/Fields/Field_Quantity.php 100.00% <0.00%> (+28.57%) ⬆️
src/Helper/Fields/Field_Total.php 91.30% <0.00%> (+30.43%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jakejackson1
Copy link
Member Author

jakejackson1 commented Sep 14, 2022

@jestonihpi looks like Gravity Wiz strikes again! They have done something similar with their snippets: https://github.com/gravitywiz/snippet-library/blob/master/gravity-forms/gw-conditional-logic-entry-meta.php#L165-L179. Note: there's currently no license included with this snippet, so use it as a reference for how you hook into Gravity Forms to add custom conditional logic.

@jestonihpi
Copy link
Contributor

@jakejackson1 . Woot! noted.

@jakejackson1
Copy link
Member Author

@jestonisumande pair your work down to just Payment Status and Payment Amount for now.

@jestonihpi
Copy link
Contributor

Copy @jakejackson1 .

@jestonihpi jestonihpi closed this Oct 25, 2022
@jestonihpi jestonihpi force-pushed the pdf_conditional_logic_improvements branch from 7aa5aed to 0328507 Compare October 25, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Entry Meta as PDF Conditional Logic Options
2 participants