Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Entry Meta as PDF Conditional Logic Options #1501

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

jakejackson1
Copy link
Member

@jakejackson1 jakejackson1 commented Feb 27, 2024

Description

This PR adds a bunch of new condition options available for PDFs, such as:

  • Entry ID
  • Status
  • Entry Date
  • Starred
  • IP Address
  • Source URL
  • Payment Status
  • Payment Date
  • Payment Amount
  • Unique ID
  • Additional entry meta data, like Quiz results or GravityView Approval status

Resolves #1404

Testing instructions

  1. Reload a form with a bunch of entries which varies each of the above items
  2. Setup PDFs on the form with unique conditional logic combinations
  3. Verify the correct PDF is active for the entry

Screenshots

CleanShot 2024-02-27 at 13 03 07

Checklist:

  • I've tested the code.
  • My code is easy to read, follow, and understand
  • My code follows the accessibility standards.
  • My code has proper inline documentation / docblocks.

Additional Comments

Props to the Gravity Wiz team for creating the original snippet this code is based on, and licensing it under GPLv2: https://github.com/gravitywiz/snippet-library/blob/master/gravity-forms/gw-conditional-logic-entry-meta.php

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 94.20290% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 77.26%. Comparing base (692feee) to head (9fea008).

Files Patch % Lines
src/Helper/Helper_Data.php 94.01% 10 Missing ⚠️
src/Controller/Controller_Form_Settings.php 93.54% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1501      +/-   ##
===============================================
+ Coverage        76.99%   77.26%   +0.26%     
===============================================
  Files              243      243              
  Lines            12516    12716     +200     
  Branches           370      370              
===============================================
+ Hits              9637     9825     +188     
- Misses            2871     2883      +12     
  Partials             8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakejackson1 jakejackson1 merged commit 798217d into development Feb 27, 2024
16 checks passed
@jakejackson1 jakejackson1 deleted the pdf-conditional-logic branch February 27, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Entry Meta as PDF Conditional Logic Options
1 participant