refactor: upgrade yarn, respect yarn options to not run postinstall #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmenko
commented
Aug 29, 2022
sources/commands/postinstall.ts
Outdated
Comment on lines
9
to
14
| // Respect the variable `YARN_ENABLE_SCRIPTS`. | ||
| // https://github.com/renovatebot/renovate/discussions/17442#discussioncomment-3498940 | ||
| if (process.env.YARN_ENABLE_SCRIPTS === "0") { | ||
| console.log(`Skipping postinstall because of "YARN_ENABLE_SCRIPTS=0"`); | ||
| return; | ||
| } |
emmenko
commented
Aug 29, 2022
sources/commands/postinstall.ts
Outdated
Comment on lines
16
to
21
| // Respect the mode `skip-build`. | ||
| // https://github.com/renovatebot/renovate/discussions/17442#discussioncomment-3499080 | ||
| if (options?.mode === InstallMode.SkipBuild) { | ||
| console.log(`Skipping postinstall because of "--mode=skip-build"`); | ||
| return; | ||
| } |
|
@emmenko, thanks for your pull request! Hope this change will be merged eventually. Meanwhile, I'll switch to your fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
Fixes #4
Additionally fixes the command to always be executed from the workspace root folder.
Other notable changes:
.yarn/cachefrom git