Skip to content
This repository has been archived by the owner on Mar 21, 2023. It is now read-only.

Specify type of 'value' (single or multi) for lookup functions. #217

Merged
merged 2 commits into from Oct 15, 2017
Merged

Specify type of 'value' (single or multi) for lookup functions. #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b783eb
Specify type of 'value' (single or multi) for lookup functions.
supahgreg Oct 14, 2017
fe9a709
Improve descriptions of the lookup functions.
supahgreg Oct 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugin/src/main/java/org/graylog/plugins/pipelineprocessor/functions/lookup/Lookup.java
View file
Open in desktop
Expand Up @@ -35,7 +35,7 @@ public Lookup(LookupTableService lookupTableService) {
.description("The key to lookup in the table")
.build();
defaultParam = object("default")
.description("The default that should be used if there is no lookup result")
.description("The default multi value that should be used if there is no lookup result")
.optional()
.build();
}
Expand All @@ -62,7 +62,7 @@ public FunctionDescriptor<Map<Object, Object>> descriptor() {
//noinspection unchecked
return FunctionDescriptor.<Map<Object, Object>>builder()
.name(NAME)
.description("Looks a value up in the named lookup table.")
.description("Looks up a multi value in the named lookup table.")
.params(lookupTableParam, keyParam, defaultParam)
.returnType((Class<? extends Map<Object, Object>>) new TypeLiteral<Map<Object, Object>>() {}.getRawType())
.build();
Expand Down
4 changes: 2 additions & 2 deletions plugin/src/main/java/org/graylog/plugins/pipelineprocessor/functions/lookup/LookupValue.java
View file
Open in desktop
Expand Up @@ -30,7 +30,7 @@ public LookupValue(LookupTableService lookupTableService) {
.description("The key to lookup in the table")
.build();
defaultParam = object("default")
.description("The default that should be used if there is no lookup result")
.description("The default single value that should be used if there is no lookup result")
.optional()
.build();
}
Expand All @@ -57,7 +57,7 @@ public FunctionDescriptor<Object> descriptor() {
//noinspection unchecked
return FunctionDescriptor.builder()
.name(NAME)
.description("Looks a value up in the named lookup table.")
.description("Looks up a single value in the named lookup table.")
.params(lookupTableParam, keyParam, defaultParam)
.returnType(Object.class)
.build();
Expand Down