performance markers

Graylog2 · Oct 25, 2010 · 81fc234 · 81fc234
1 parent 7007651
commit 81fc234
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/org/graylog2/database/MongoBridge.java b/src/main/java/org/graylog2/database/MongoBridge.java
@@ -66,6 +66,7 @@ public DBCollection getMessagesColl() {
             coll = MongoConnection.getInstance().getDatabase().createCollection("messages", BasicDBObjectBuilder.start().add("capped", true).add("size", messagesCollSize).get());
         }
 
+        // XXX PERFORMANCE
         coll.ensureIndex(new BasicDBObject("created_at", 1));
         coll.ensureIndex(new BasicDBObject("host", 1));
         coll.ensureIndex(new BasicDBObject("facility", 1));
@@ -103,7 +104,7 @@ public void insert(SyslogServerEventIF event) throws Exception {
      */
     public void insertGelfMessage(GELFMessage message) throws Exception {
         // Check if all required parameters are set.
-        if (message.getShortMessage() == null || message.getShortMessage().length() == 0 || message.getHost() == null || message.getHost().length() == 0) {
+        if (message.getShortMessage() == null || message.getHost() == null  || message.getShortMessage().length() == 0 || message.getHost().length() == 0) {
             throw new Exception("Missing GELF message parameters. short_message and host are required.");
         }
         DBCollection coll = this.getMessagesColl();
@@ -119,7 +120,7 @@ public void insertGelfMessage(GELFMessage message) throws Exception {
         dbObj.put("facility", null);
         dbObj.put("level", message.getLevel());
 
-        // Add additional fields.
+        // Add additional fields. XXX PERFORMANCE
         Map<String,String> additionalFields = message.getAdditionalData();
         Set<String> set = additionalFields.keySet();
         Iterator<String> iter = set.iterator();

diff --git a/src/main/java/org/graylog2/messagehandlers/gelf/SimpleGELFClientHandler.java b/src/main/java/org/graylog2/messagehandlers/gelf/SimpleGELFClientHandler.java
@@ -91,7 +91,6 @@ public boolean handle() {
             // Connect to database.
             MongoBridge m = new MongoBridge();
 
-
             // Log if we are in debug mode.
             Log.info("Got GELF message: " + message.toString());