Use english locale explicitly when finding widget subclass. #11637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
force-pushed
the
fix/issue-11596
branch
from
86750e8
to
f2780fd
Compare
dennisoelkers
force-pushed
the
fix/issue-11596
branch
from
f2780fd
to
1f1f761
Compare
supahgreg
reviewed
Nov 17, 2021
| @@ -108,7 +108,7 @@ class Widget { | |||
| streams, | |||
| } = this._value; | |||
|
|
|||
| return { id, type: type.toLocaleLowerCase(), config, filter, timerange, query, streams }; | |||
| return { id, type: type.toLowerCase(), config, filter, timerange, query, streams }; | |||
There was a problem hiding this comment.
Oh yeah, that's much better than .toLocaleLowerCase('en'). Went ahead and updated #11601, just in case.
linuspahl
reviewed
Nov 18, 2021
linuspahl
approved these changes
Nov 18, 2021
linuspahl
pushed a commit
that referenced
this pull request
Nov 18, 2021
* Use english locale explicitly when finding widget subclass. * Simplifying fix. Thanks @linuspahl!
linuspahl
pushed a commit
that referenced
this pull request
Nov 18, 2021
* Use english locale explicitly when finding widget subclass. * Simplifying fix. Thanks @linuspahl!
This was referenced Nov 18, 2021
Merged
dennisoelkers
added a commit
that referenced
this pull request
Nov 18, 2021
…11657) * Use english locale explicitly when finding widget subclass. * Simplifying fix. Thanks @linuspahl! Co-authored-by: Dennis Oelkers <dennis@graylog.com>
dennisoelkers
added a commit
that referenced
this pull request
Nov 18, 2021
…11658) * Use english locale explicitly when finding widget subclass. * Simplifying fix. Thanks @linuspahl! Co-authored-by: Dennis Oelkers <dennis@graylog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Note: This requires a backport to
4.2.Prior to this PR we were using the default locales when converting widget types to lower case. For the turkish language, this can lead to certain characters being changed in an unexpected way.
This PR is now using the
enlocale explicitly when lowercasing the widget type.Thanks to @supahgreg for his work in #11601.
Fixes #11596.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: