Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenCollectingQueryParser.getBooleanQuery() is prone to create NPEs (Backport #13054 to 4.3) #13089

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

janheise
Copy link
Contributor

Description

see the error description in the issue #13037

Our own Parser returned a result in getBooleanQuery() even if the superclass returns null in the same case. This PR fixes this behaviour.

Note: backport to 4.3 from #13054

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers merged commit c69dfb1 into 4.3 Jul 20, 2022
@dennisoelkers dennisoelkers deleted the fix/13037_NPE_Validating_search_backport_4_3 branch July 20, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants