Allow Show Top Values action for enumerable compound fields.
#13782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
force-pushed
the
fix/allow-top-values-for-compound-types
branch
from
2764c4c
to
74b2772
Compare
linuspahl
approved these changes
Oct 26, 2022
linuspahl
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Allow `Show Top Values` action for enumerable compound fields. * Adding test.
Merged
9 tasks
dennisoelkers
added a commit
that referenced
this pull request
Nov 1, 2022
… (#13795) * Allow `Show Top Values` action for enumerable compound fields. * Adding test. Co-authored-by: Dennis Oelkers <dennis@graylog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This should be backported to
4.3.Motivation and Context
Prior to this PR, the
Show top valuesaction was disabled when the field it is triggered on is a compound field. This is too strict, because if all of the field types composing this compound field type are enumerable, then it is also possible to show the top values.This PR is now changing the predicate to check if the field type is enumerable instead of if it is a compound type.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: