Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES/OS error causes without index data are handled properly #14203

Merged
merged 2 commits into from
Dec 20, 2022
Merged

ES/OS error causes without index data are handled properly #14203

merged 2 commits into from
Dec 20, 2022

Conversation

luk-kaminski
Copy link
Contributor

@luk-kaminski luk-kaminski commented Dec 13, 2022 •
edited by dennisoelkers
Loading

Note: This needs a backport to 5.0.

Description

ES/OS error causes without index data are handled properly.
Fixes #13221.

Additionally, the code has been refactored a little bit to remove code duplication.

How Has This Been Tested?

Simple unit test have been added.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

dennisoelkers
dennisoelkers approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@dennisoelkers dennisoelkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙏

@dennisoelkers dennisoelkers merged commit c144778 into master Dec 20, 2022
@dennisoelkers dennisoelkers deleted the fix/error_handling branch December 20, 2022 08:53
luk-kaminski added a commit that referenced this pull request Dec 20, 2022
@luk-kaminski
ES/OS error causes without index data are handled properly (#14203)
d17ee4c 
* ES/OS error causes without index data are handled properly

* Adding changelog entry
@luk-kaminski luk-kaminski mentioned this pull request Dec 20, 2022
Merged
9 tasks
dennisoelkers pushed a commit that referenced this pull request Dec 21, 2022
@luk-kaminski
ES/OS error causes without index data are handled properly (#14203) (#…
818ce36 
…14263)

* ES/OS error causes without index data are handled properly

* Adding changelog entry
ousmaneo pushed a commit that referenced this pull request Jan 11, 2023
@luk-kaminski @ousmaneo
ES/OS error causes without index data are handled properly (#14203)
cd9dc83 
* ES/OS error causes without index data are handled properly

* Adding changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisoelkers dennisoelkers dennisoelkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Occasional Cause "Missing required properties: indexUuid index" after switch to ES7
2 participants
@luk-kaminski @dennisoelkers