Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close IndexSet the delete modal and reload list after deleting. #19030

Merged
merged 4 commits into from
May 7, 2024
Merged

Close IndexSet the delete modal and reload list after deleting. #19030

merged 4 commits into from
May 7, 2024

Conversation

ousmaneo
Copy link
Contributor

@ousmaneo ousmaneo commented Apr 12, 2024 •
edited

These changes fix some issues on the index set deletion UI.

  • Close the modal after delete
  • reload list

Fix #18994 #18693

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ousmaneo ousmaneo self-assigned this Apr 12, 2024
gally47
gally47 approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it.

@ousmaneo ousmaneo merged commit 07eacef into master May 7, 2024
6 checks passed
@ousmaneo ousmaneo deleted the issue-18994 branch May 7, 2024 08:36
ousmaneo added a commit that referenced this pull request May 8, 2024
@ousmaneo @gally47
Close IndexSet the delete modal and reload list after deleting. (#19030)
0e5b8ea 
* close modal and reload after delete

* add changelog

---------

Co-authored-by: Mohamed OULD HOCINE <106236152+gally47@users.noreply.github.com>
@ousmaneo ousmaneo mentioned this pull request May 8, 2024
Merged
9 tasks
ousmaneo added a commit that referenced this pull request May 8, 2024
@ousmaneo @gally47
Close IndexSet the delete modal and reload list after deleting. (#19030…
4a95489 
…) (#19294)

* close modal and reload after delete

* add changelog

---------

Co-authored-by: Mohamed OULD HOCINE <106236152+gally47@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gally47 gally47 gally47 approved these changes

@grotlue grotlue Awaiting requested review from grotlue

Assignees

@ousmaneo ousmaneo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index set deletion problems
2 participants
@ousmaneo @gally47