Make alert conditions resilient against changing number formats. #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding some tests as well. |
In 1.3.x numerical alert condition parameters were stored by MongoDB (resp. the mongo java driver) in a way, that they are returned as Doubles to the server, while alert conditions persisted in 2.0.0 return numerical parameters as Integer. Therefore, 2.0.0 cannot handle alert conditions stored in 1.3.x, so legacy installations upgraded to 2.0.0 do not check any alert conditions anymore. This change allows to handle both formats by generally assuming they are Number/Double types and returning their `intValue()`. Fixes #2169
This also helps us, because the "threshold" parameter could also be a double in some cases.
| @@ -195,4 +187,16 @@ public NegativeCheckResult(AlertCondition alertCondition) { | |||
| } | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
There was a problem hiding this comment.
Minor semantic nitpick: Child classes are also using this (protected) method, so it's not just visible for testing. 😉
|
|
||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.Assert.*; |
There was a problem hiding this comment.
Please don't use wildcard imports.
Configuration for IntelliJ IDEA: http://stackoverflow.com/a/3348855
|
LGTM (except for those 2 minor nitpicks). 👍 |
|
LGTM. 👍 |
dennisoelkers
added a commit
that referenced
this pull request
May 9, 2016
In 1.3.x numerical alert condition parameters were stored by MongoDB (resp. the Mongo Java Driver) in a way, that they are returned as Double while alert conditions persisted in 2.0.0 return numerical parameters as Integer. Therefore, 2.0.0 cannot handle alert conditions stored in 1.3.x and legacy installations upgraded to 2.0.0 do not check any alert conditions anymore. This change allows to handle both formats by generally assuming they are Number/Double types and returning their `intValue()`. Fixes #2169 (cherry picked from commit d164e7f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.3.x numerical alert condition parameters were stored by MongoDB
(resp. the mongo java driver) in a way, that they are returned as
Doubles to the server, while alert conditions persisted in 2.0.0 return
numerical parameters as Integer. Therefore, 2.0.0 cannot handle alert
conditions stored in 1.3.x, so legacy installations upgraded to 2.0.0
do not check any alert conditions anymore.
This change allows to handle both formats by generally assuming they are
Number/Double types and returning their
intValue().Fixes #2169