Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timer metric to extractor condition #2959

Closed
kroepke opened this issue Oct 17, 2016 · 0 comments
Closed

Add timer metric to extractor condition #2959

kroepke opened this issue Oct 17, 2016 · 0 comments
Assignees
@joschi @kroepke
Labels
feature improvement low hanging fruit
Milestone
2.2.0

Comments

@kroepke
Copy link
Member

kroepke commented Oct 17, 2016

Currently extractors have two different timers:

  • executionTime
  • converterExecutionTime

However, the condition is evaluated outside of the executionTime and we also do not track how many extractor conditions prevented running the extractor.

Add another timer which tracks the condition execution and counts how many times the condition was evaluated.
This helps catching slow (potentially backtracking) regex conditions.
@kroepke kroepke added this to the 2.2.0 milestone Oct 17, 2016
@kroepke kroepke changed the title Extractor conditions are not timed Add timer metric to extractor condition Oct 17, 2016
@joschi joschi mentioned this issue Jan 4, 2017
Closed
@joschi joschi self-assigned this Jan 10, 2017
joschi pushed a commit that referenced this issue Jan 10, 2017
Add more metrics for extractors
a4efae2 
This change adds the following metrics for extractors:

* Added conditionHits (number of times the condition succeeded)
* Added conditionMisses (number of times the condtion failed)
* Added conditionTime (time spent in evaluating the condition)
* completeExecutionTime (total time spent in the extractor)

Fixes #2959
@joschi joschi mentioned this issue Jan 10, 2017
Merged
@ghost ghost assigned kroepke Jan 11, 2017
@ghost ghost removed the in progress label Jan 11, 2017
kroepke pushed a commit that referenced this issue Jan 11, 2017
@joschi @kroepke
Add more metrics for extractors (#3332)
7d88616 
* Add more metrics for extractors

This change adds the following metrics for extractors:

* Added conditionHits (number of times the condition succeeded)
* Added conditionMisses (number of times the condtion failed)
* Added conditionTime (time spent in evaluating the condition)
* completeExecutionTime (total time spent in the extractor)

Fixes #2959

* Precreate Timers in Extractor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joschi joschi

@kroepke kroepke

Labels
feature improvement low hanging fruit
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@joschi @kroepke