Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable alarm notification controls if user is not permitted to edit. #3303

Merged
merged 1 commit into from
Jan 5, 2017
Merged

Disable alarm notification controls if user is not permitted to edit. #3303

merged 1 commit into from
Jan 5, 2017

Conversation

dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jan 5, 2017 •
edited
Loading

This PR checks for the stream edit permission on the stream an alarm
notification belongs to and disables functionality it is required for
(test/edit/delete buttons).

Fixes #3302, #2502.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dennisoelkers
Disable alarm notification controls if user is not permitted to edit.
b08a9d6 
This PR checks for the stream edit permission on the stream an alarm
notification belongs to and disables functionality it is required for
(test/edit/delete buttons).

Fixes #3302.
@dennisoelkers dennisoelkers added this to the 2.2.0 milestone Jan 5, 2017
@dennisoelkers dennisoelkers mentioned this pull request Jan 5, 2017
Closed
@joschi joschi self-assigned this Jan 5, 2017
@joschi joschi merged commit d04fdfd into master Jan 5, 2017
@joschi joschi deleted the issue-3302 branch January 5, 2017 14:28
@luk-kaminski luk-kaminski mentioned this pull request Mar 14, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschi joschi joschi approved these changes

Assignees

@joschi joschi

Labels
alerting bug
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Alarm Notification edit controls shown for user lacking permission
2 participants
@dennisoelkers @joschi