New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dashboard from search page do not select the right ID #3785

Closed
edmundoa opened this Issue May 5, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@edmundoa
Member

edmundoa commented May 5, 2017

For a few versions it is possible to create a dashboard from the search page if none existed (and the user has the right permissions for it) and then add the widget to that dashboard.

In the current master, this functionality is broken, as the code tries to use undefined as dashboard ID, instead of the actual dashboard ID.

Expected Behavior

Creating a widget after adding a dashboard should work.

Current Behavior

Creating a widget after adding a dashboard uses the wrong dashboard ID and fails.

Steps to Reproduce (for bugs)

  1. Start with a Graylog setup with no dashboards and an admin user
  2. Go to the search page and add a widget to the dashboard
  3. Create a new dashboard by filling out the form and try to add the widget to that dashboard
  4. See that there is an error message and the URL uses undefined as dashboard ID

Your Environment

  • Graylog Version: Graylog 2.3.0-alpha.1

@edmundoa edmundoa added bug web labels May 5, 2017

@edmundoa edmundoa added this to the 2.3.0 milestone May 5, 2017

@edmundoa edmundoa self-assigned this May 5, 2017

@edmundoa

This comment has been minimized.

Member

edmundoa commented May 5, 2017

This seems to be a leftover from #3598

edmundoa added a commit that referenced this issue May 5, 2017

Use dashboard ID to add widget on new dashboard
Since #3598, the method signature for `this_selectDashboard` changed,
but this usage was not updated.

Fixes #3785

@edmundoa edmundoa added the in progress label May 5, 2017

@wafflebot wafflebot bot removed the in progress label May 8, 2017

dennisoelkers added a commit that referenced this issue May 8, 2017

Use dashboard ID to add widget on new dashboard (#3786)
Since #3598, the method signature for `this_selectDashboard` changed,
but this usage was not updated.

Fixes #3785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment