Convert timestamp quickvalues to formatted date #4423
Conversation
…e to formatted date otherwise the search store will end up searching for the unix timestamp which is not supported fixes #4288
ghost
assigned 
|
|
||
| if (this.props.field === 'timestamp') { | ||
| // convert unix timestamp to proper formatted value, so that add to search button works correctly | ||
| formattedTerm = moment.utc(Number(d.term)).format(DateTime.Formats.TIMESTAMP); |
There was a problem hiding this comment.
This does not display date times in the user time zone, providing inconsistent values with the search results. We should use new DateTime(Number(d.term)).toString(DateTime.Formats.TIMESTAMP) to get the time formatted in the user's time zone.
| columns.push(d => this._getAddToSearchButton(d.term)); | ||
| if (this.props.field === 'timestamp') { | ||
| // convert unix timestamp to proper formatted value, so that add to search button works correctly | ||
| columns.push(d => this._getAddToSearchButton(moment.utc(Number(d.term)).format(DateTime.Formats.TIMESTAMP))); |
There was a problem hiding this comment.
This also has problems with the user TZ, as the value from here is later converted into UTC (see gif below) and when pressing the search button we can't find any results. We should use, as in the other case new DateTime(Number(d.term)).toString(DateTime.Formats.TIMESTAMP) to convert the unix time in the user's selected time zone.
There was a problem hiding this comment.
By the way, as both date times should be formatted the same way, I would extract the conversion into a function for extra clarity.
extract repeated code into function
|
Moving to 3.0.0 milestone. |
* when displaying quick values for the timestamp field convert unix time to formatted date otherwise the search store will end up searching for the unix timestamp which is not supported fixes #4288 * respect timezones when stringifying extract repeated code into function (cherry picked from commit b4af02b)
otherwise the search store will end up searching for the unix timestamp which is not supported
fixes #4288