Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display all LDAP mapped groups (#7513) #7697

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Display all LDAP mapped groups (#7513) #7697

merged 1 commit into from
Mar 17, 2020

Conversation

edmundoa
Copy link
Contributor

Backport of #7513:

In the LDAP group mapping page, display groups having a mapping configured, regardless if they match the current group configuration or not. This let users remove previously configured mappings if they ever changed their group configuration.

Additionally, add a reminder in the LDAP configuration page to review group mapping after changes in the group configuration are made.

Fixes #7502

Display all LDAP mapped groups (#7513)
76810a5 
* Display previous group mappings in configuration
  Display assigned (and active) group mappings even if they don't match
  the current LDAP/AD group search pattern.
* Add reminder to update LDAP/AD group mapping
  Remind users tor review group mapping after changes in group
  configuration.
* Detect when LDAP is enabled in group mapping
* Update `LdapGroupsComponent`
  - Fix isLoading method
  - Fix linter errors
  - Fix sorting
  - Use combined provider
* Update LdapComponent component
  - Convert to class component
  - Fix all linter issues
  - Load LDAP settings on mount, avoiding stale state
  - Fix console warnings

(cherry picked from commit 6b53d94)
@edmundoa edmundoa added this to the 3.2.4 milestone Mar 17, 2020
@edmundoa edmundoa requested a review from bernd March 17, 2020 14:39
@bernd bernd self-assigned this Mar 17, 2020
@bernd bernd merged commit c2378da into 3.2 Mar 17, 2020
@bernd bernd deleted the issue-7502-3.2 branch March 17, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernd bernd bernd approved these changes

Assignees

@bernd bernd

Labels
None yet
Projects
None yet
Milestone
3.2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundoa @bernd