Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset overlay dropdown placement (Backport of #7658 for 3.2) #7723

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Reset overlay dropdown placement (Backport of #7658 for 3.2) #7723

merged 2 commits into from
Mar 19, 2020

Conversation

alex-konn
Copy link
Contributor

@alex-konn alex-konn commented Mar 19, 2020 •
edited by linuspahl
Loading

Backport of #7658 for 3.2

As described here: #7631 (review) the overlay dropdown placement can be wrong. This happens when you:

  1. Have a widget on the right side of the search page grid
  2. Use the context menu
  3. Move the widget to the left side
  4. Use the context menu again.

This PR fixes the problem by resetting the placement, when the opposite placement is no longer suitable.

I will create backport for 3.2 once this PR got merged

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@linuspahl linuspahl added this to the 3.2.4 milestone Mar 19, 2020
@linuspahl linuspahl self-requested a review March 19, 2020 16:05
@linuspahl linuspahl changed the title Reset overlay dropdown placement 3.2 Reset overlay dropdown placement (Backport of #7658 for 3.2) Mar 19, 2020
linuspahl
linuspahl approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works as expected

@linuspahl linuspahl merged commit 3d7aebb into 3.2 Mar 19, 2020
@linuspahl linuspahl deleted the reset-overlay-dropdown-placement-3.2 branch March 19, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linuspahl linuspahl linuspahl approved these changes

Assignees
No one assigned
Labels
backport ready-for-review User Experience
Projects
None yet
Milestone
3.2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-konn @linuspahl