Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow view deletion for users with view edit permissions #7817

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Allow view deletion for users with view edit permissions #7817

merged 1 commit into from
Apr 3, 2020

Conversation

linuspahl
Copy link
Contributor

Currently only admins are able to delete a view (dashboard / saved search).
With this PR we are allowing all users with view edit rights to delete a view.
This behaviour matches the permissions logic of comparable cases in the application.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@linuspahl linuspahl changed the title Allow view deletion for users with view edit rights Allow view deletion for users with view edit permissions Apr 2, 2020
@linuspahl linuspahl mentioned this pull request Apr 2, 2020
Merged
9 tasks
kmerz
kmerz approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@kmerz kmerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kmerz kmerz merged commit 9348c3b into master Apr 3, 2020
@kmerz kmerz deleted the change-view-delete-backend-permission branch April 3, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmerz kmerz kmerz approved these changes

@dennisoelkers dennisoelkers Awaiting requested review from dennisoelkers

Assignees
No one assigned
Labels
ready-for-review search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linuspahl @kmerz