Removing legacy Aggregation API. #8329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-konn
suggested changes
Jun 12, 2020
| @@ -61,12 +45,9 @@ | |||
|
|
|||
| public class SearchesAdapterES6 implements SearchesAdapter { | |||
There was a problem hiding this comment.
The public method createTermsBuilder and the constant AGG_TERMS can be deleted too.
| @@ -196,57 +191,6 @@ public SearchResult search(SearchesConfig config) { | |||
| return result; | |||
| } | |||
|
|
|||
| public TermsResult terms(String field, List<String> stackedFields, int size, String query, String filter, TimeRange range, Sorting.Direction sorting) { | |||
There was a problem hiding this comment.
The constant STACKED_TERMS_AGG_SEPARATOR, and the enums TermsStatsOrder, and DateHistogramInterval can be deleted too.
| @@ -79,13 +70,6 @@ public SearchResource(Searches searches, | |||
| this.decoratorProcessor = decoratorProcessor; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The protected method splitStackedFields can be deleted too.
dennisoelkers
force-pushed
the
remove-legacy-aggregation-api
branch
from
6edd509
to
15945ce
Compare
alex-konn
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
As previously announced (in be12bfe),
the legacy aggregation API is removed in
4.0. This PR is taking allthe required steps and prunes related classes and files.
For further details, please see #8323.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: