Prevent single number widget flickering (Backport of #8291 for 3.3) #8341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor AutoFontSizer code style * Increase tolerance when calculating most appropriate font size * Refactor AutoFontSizer code style * Move module constants tolerance and child size ratio to module scope * Create separate function to check if a font size is valid * Add JSDoc comment for the component * Fixing typo * Update AutoFontSizer JSDoc comment * Improve AutoFontSizer JSDoc comment
dennisoelkers
approved these changes
Jun 17, 2020
dennisoelkers
deleted the
issue-7563-fix-single-number-widget-flickering-3.3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #8291 for 3.3
As described in #7563 the single number widget can flicker when the widget has a small height.
This happened because the font size always changed between
11pxand10px. in both cases the defined tolerance did not matched. This PR is fixing the issue by increasing the tolerance. It also refactors theAutoFontSizercode style.The issue is currently not occurring on the master branch, because #8064 changed the widget content height. You can reproduce the error, by checking out the commit
ed8998c3251and following the steps in the mentioned issue.Fixes #7563
Types of changes