Define bar width if bar chart contains only data for a single date #8354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
commented
Jun 16, 2020
| @@ -31,7 +31,7 @@ export type VisualizationComponentProps = { | |||
| config: AggregationWidgetConfig, | |||
| data: { [string]: Rows, events?: Events }, | |||
| editing?: boolean, | |||
| effectiveTimerange: TimeRange, | |||
| effectiveTimerange: AbsoluteTimeRange, | |||
There was a problem hiding this comment.
As far as I know the effective time range is always an AbsoluteTimeRange. Or is there a case were it can be another type?
linuspahl
commented
Jun 16, 2020
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| type ConfigType = { [string]: mixed }; | |||
|
|
|||
| export const DateType = 'time'; | |||
| export const ValuesType = 'values'; | |||
There was a problem hiding this comment.
I will create a follow up PR to replace all related hard coded values.
dennisoelkers
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #7167 a bar chart with a time range and only one search result, results in one very small bar. This PR is fixing the problem by defining a width for the bar. The width can't be defined in px, it has to be the unit of the x axis (in this case ms).
Fixes #7167
Screenshots (if appropriate):
Types of changes