Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement first version of new aggregation controls, including support for metric configuration. #10281

Merged
merged 66 commits into from
Mar 22, 2021
Merged

Implement first version of new aggregation controls, including support for metric configuration. #10281

merged 66 commits into from
Mar 22, 2021

Commits on Mar 22, 2021

  1. Creating basic AggregationWizard component.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    ea3d5b8 View commit details
    Browse the repository at this point in the history

  2. Creating basic components for aggregation attribute configuration.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    e316666 View commit details
    Browse the repository at this point in the history

  3. Rename aggregation attribute to aggregation action.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    40513a8 View commit details
    Browse the repository at this point in the history

  4. Improve aggregation actions structure and expandability.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    a582e48 View commit details
    Browse the repository at this point in the history

  5. Fixing typo.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    4631576 View commit details
    Browse the repository at this point in the history

  6. Fixing headline font size and AggregationWizard props.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    cdcaddd View commit details
    Browse the repository at this point in the history

  7. Creating test for AggregationActionSelect.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    3737a6a View commit details
    Browse the repository at this point in the history

  8. Creating test for ActionConfigurationContainer.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    2bbc462 View commit details
    Browse the repository at this point in the history

  9. Creating test for AggregationWizard.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    5d55afb View commit details
    Browse the repository at this point in the history

  10. Clearing AggregationActionSelect value after selection an action.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    d4faddb View commit details
    Browse the repository at this point in the history

  11. Renaming aggregation action properties label to title and value to key.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    4c45202 View commit details
    Browse the repository at this point in the history

  12. Reverting AggregationWizard usage in views bindings.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    d9bdc61 View commit details
    Browse the repository at this point in the history

  13. Fixing linter warnings.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    b69e575 View commit details
    Browse the repository at this point in the history

  14. List aggregation action in AggregationActionSelect if it can be con… 

    …figured multiple times.
    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    f6e4b42 View commit details
    Browse the repository at this point in the history

  15. Renaming aggregation action to aggregation element.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    4c2d08e View commit details
    Browse the repository at this point in the history

  16. Do not add new section for an already configured aggregation action.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    9ab826a View commit details
    Browse the repository at this point in the history

  17. Removing no longer needed createDefault series method.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    9b7baa5 View commit details
    Browse the repository at this point in the history

  18. Changing order of configured aggregation elements.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    465e30a View commit details
    Browse the repository at this point in the history

  19. Always display configured aggregation elements in correct order.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    41fa08f View commit details
    Browse the repository at this point in the history

  20. Updating AggregationElementSelect.test.`

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    4ac3736 View commit details
    Browse the repository at this point in the history

  21. Creating WidgetConfigForm.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    0a1f8bf View commit details
    Browse the repository at this point in the history

  22. Moving SearchBarForm from EditWidgetFrame to WidgetQueryControls.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    a3eee78 View commit details
    Browse the repository at this point in the history

  23. Rename MetricConfiguration to MetricsConfiguration.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    602f72e View commit details
    Browse the repository at this point in the history

  24. Creating basic metric form with function and field select.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    4b7a698 View commit details
    Browse the repository at this point in the history

  25. Enable widget configuration update for metrics.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    bc05ecf View commit details
    Browse the repository at this point in the history

  26. Providing correct initial values for metrics configuration form.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    125588f View commit details
    Browse the repository at this point in the history

  27. Removing no longer needed aggregation wizard state by using `WidgetCo… 

    …nfigForm` only.
    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    d4feb45 View commit details
    Browse the repository at this point in the history

  28. Updating type definition of SeriesConfig value and constructor.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    46ad7dc View commit details
    Browse the repository at this point in the history

  29. Splitting up AggregationWizard in multiple components.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    7e90b1a View commit details
    Browse the repository at this point in the history

  30. Migrating AggregationFunctionsStore to ts.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    d2c9735 View commit details
    Browse the repository at this point in the history

  31. Importing aggregation functions for metrics configuration directly fr… 

    …om `AggregationFunctionsStore`.
    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    400b516 View commit details
    Browse the repository at this point in the history

  32. Reverting Series and SeriesConfiguration constructor type definit… 

    …ion changes.
    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    2ce4f05 View commit details
    Browse the repository at this point in the history

  33. Fixing type imports

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    16f4669 View commit details
    Browse the repository at this point in the history

  34. Only display aggregation element configuraion container if form has r… 

    …elated values.
    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    0af7525 View commit details
    Browse the repository at this point in the history

  35. Validating metric functions, triggering manual validation on initial … 

    …mount.
    @dennisoelkers
    dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    67f9b45 View commit details
    Browse the repository at this point in the history

  36. Validate form on change/on mount.

    @dennisoelkers
    dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    dae34fe View commit details
    Browse the repository at this point in the history

  37. Switching from field-level to form-level validation.

    @dennisoelkers
    dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    1e59e28 View commit details
    Browse the repository at this point in the history

  38. Handling percentile parameter for percentile function.

    @dennisoelkers
    dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    da59c90 View commit details
    Browse the repository at this point in the history

  39. Do not include metrics errors in validation result if empty.

    @dennisoelkers
    dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    198b5e6 View commit details
    Browse the repository at this point in the history

  40. Include name field for metric.

    @dennisoelkers
    dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    338731b View commit details
    Browse the repository at this point in the history

  41. Include placeholder for name field.

    @dennisoelkers
    dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    dd51122 View commit details
    Browse the repository at this point in the history

  42. Fixing vertical scrolling of aggregation elements column in aggregati… 

    …on wizard.

(cherry picked from commit 0efd3b2)
    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    08e315d View commit details
    Browse the repository at this point in the history

  43. Styling fixes

    @dennisoelkers
    dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    329f1a6 View commit details
    Browse the repository at this point in the history

  44. Removing section headlines to save vertical space.

    @dennisoelkers
    dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    d1c8603 View commit details
    Browse the repository at this point in the history

  45. Fixing horizontal scrolling of element configuration containers by ad… 

    …justing bootstrap elements padding.

The negative row / form-group margin caused the horizontal scroll bar.
    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    bf32d7f View commit details
    Browse the repository at this point in the history

  46. Creating one file for each aggregation element.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    eb688fc View commit details
    Browse the repository at this point in the history

  47. Fixing types.

    @dennisoelkers
    dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    dc11e4e View commit details
    Browse the repository at this point in the history

  48. Fixing types.

    @dennisoelkers
    dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    0620a7a View commit details
    Browse the repository at this point in the history

  49. Replacing aggregation element properties isConfigured and `multiple… 

    …Use` with `allowCreate`.
    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    3494885 View commit details
    Browse the repository at this point in the history

  50. Defining theme color for element separator.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    6a75259 View commit details
    Browse the repository at this point in the history

  51. Reducing element container padding.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    acd6127 View commit details
    Browse the repository at this point in the history

  52. Fixing allowCreate usage.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    cfa8f71 View commit details
    Browse the repository at this point in the history

  53. Providing form values as a prop for AggregationElementSelect to sim… 

    …plify testing.
    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    3217cef View commit details
    Browse the repository at this point in the history

  54. Updating AggregationElementSelect.test.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    28ce5d0 View commit details
    Browse the repository at this point in the history

  55. Udpating MetricsConfiguration.test.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    1bf0f9c View commit details
    Browse the repository at this point in the history

  56. Adding missing key in MetricsConfiguration.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    797fd72 View commit details
    Browse the repository at this point in the history

  57. Extend PropType definition for common Select value with number.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    a3cfe9f View commit details
    Browse the repository at this point in the history

  58. Extending AgggregationWizard.test with tests for metrics element.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    bf3eb35 View commit details
    Browse the repository at this point in the history

  59. Fixing linter warnings

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    2c776ed View commit details
    Browse the repository at this point in the history

  60. Updating WidgetQueryControls.test regarding SearchBarForm addition.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    50ac44a View commit details
    Browse the repository at this point in the history

  61. Implement ElementConfigurationSection for MetricsConfiguration wh… 

    …ich separates each section of the metrics element configuration.
    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    f4745cb View commit details
    Browse the repository at this point in the history

  62. Test configuration of metric with multiple functions.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    4444aa1 View commit details
    Browse the repository at this point in the history

  63. Creating separate file for metric element tests.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    d044dce View commit details
    Browse the repository at this point in the history

  64. Fixing linter warnings.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    e0268a6 View commit details
    Browse the repository at this point in the history

  65. Reimplementing type definition for Widget.tsx config prop.

    @linuspahl @dennisoelkers
    linuspahl authored and dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    77aade5 View commit details
    Browse the repository at this point in the history

  66. Fixing import path.

    @dennisoelkers
    dennisoelkers committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    c450d95 View commit details
    Browse the repository at this point in the history