Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index count on IndexSetPage (4.2) #11406

Merged
merged 1 commit into from Oct 5, 2021
Merged

Fix index count on IndexSetPage (4.2) #11406

merged 1 commit into from Oct 5, 2021

Conversation

dennisoelkers
Copy link
Member

Note: This is a backport of #11395 to 4.2.

Fixes the index count on IndexSetPage.

Description

Previously, _totalIndexCount was counting the keys of the indexerOverview response (introduced w/ #10401; specifically this), rather than the response's indices key. This PR updates that function so it counts the right thing.

Motivation and Context

Fixes #11375.

How Has This Been Tested?

It hasn't been tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@supahgreg @dennisoelkers
Fix index count on IndexSetPage (#11395)
2358155 
* Fix index count on IndexSetPage.

* Fix spacing in IndexSetPage.

(cherry picked from commit 01253de)
@dennisoelkers dennisoelkers added this to the 4.2.0 milestone Oct 1, 2021
@dennisoelkers dennisoelkers requested review from ousmaneo and a team October 1, 2021 14:51
linuspahl
linuspahl approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, works as expected.

@linuspahl linuspahl merged commit 38bffa0 into 4.2 Oct 5, 2021
@linuspahl linuspahl deleted the bugfix/index-set-indices-under-mgmt-4.2 branch October 5, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linuspahl linuspahl linuspahl approved these changes

@ousmaneo ousmaneo Awaiting requested review from ousmaneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dennisoelkers @linuspahl @supahgreg