Remove support for QueryReferenceBinding parameters #11777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todvora
force-pushed
the
refactoring/remove-queryreferencebinding
branch
2 times, most recently
from
9803ce3
to
dad8c98
Compare
janheise
reviewed
Dec 14, 2021
There was a problem hiding this comment.
I checked that it still works etc., so it LGTM. But there are some classes removed (QueryPlan etc.) where I feel, I don't have enough experience yet to decide if they should be dropped from the codebase. I'd like to defer an approval to @dennisoelkers
todvora
force-pushed
the
refactoring/remove-queryreferencebinding
branch
from
dad8c98
to
cebd1ba
Compare
dennisoelkers
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1530
Description
Motivation and Context
/jenkins-pr-deps Graylog2/graylog-plugin-enterprise#3008
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: