Remove DashboardRegistry #1542
Merged
Remove DashboardRegistry #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DashboardRegistry came from a time, when there was no DashboardService and therefore it was a good idea to have a collection keeping available dashboards. This is useless now and also creates an implicit cache which produces synchronization issues when mutations are called on non-master nodes. Therefore DashboardResource operations mutating the existing state where restricted to the master node. This is neither useful, desirable nor necessary, so this PR is removing the dashboard registry and its usages.
|
LGTM. 👍 |
joschi
added a commit
that referenced
this pull request
Nov 9, 2015
Remove obsolete DashboardRegistry
joschi
added a commit
that referenced
this pull request
Nov 9, 2015
Remove obsolete DashboardRegistry (cherry picked from commit 0ccbb8a)
joschi
pushed a commit
that referenced
this pull request
Jan 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DashboardRegistry came from a time, when there was no
DashboardService and therefore it was a good idea to have a collection
keeping available dashboards. This is useless now and also creates an
implicit cache which produces synchronization issues when mutations are
called on non-master nodes. Therefore DashboardResource operations
mutating the existing state where restricted to the master node.
This is neither useful, desirable nor necessary, so this PR is removing
the dashboard registry and its usages.