Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport 5.2: set state to SKIPPED if "resume startup" is called with no data nodes… #17203

Merged
merged 1 commit into from
Nov 8, 2023
Merged

backport 5.2: set state to SKIPPED if "resume startup" is called with no data nodes… #17203

merged 1 commit into from
Nov 8, 2023

Conversation

moesterheld
Copy link
Contributor

backport for #17136

fixes #17117

  • set state to SKIPPED if resume startup is called with no datanodes

(cherry picked from commit da7cf5f)

/nocl

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@moesterheld
set state to SKIPPED if "resume startup" is called with no data nodes (…
9364795 
…#17136)

* set state to SKIPPED if resume startup is called with no datanodes

* fix test

(cherry picked from commit da7cf5f)
todvora
todvora approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@todvora todvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@todvora todvora merged commit 11245ea into 5.2 Nov 8, 2023
5 checks passed
@todvora todvora deleted the backport/5.2-datanode-skipped-state branch November 8, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todvora todvora todvora approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moesterheld @todvora