Do not render input form when type is not available. #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, the inputs page would break when the type definition for a given input is not present (for example due to a plugin not being loaded). Now we skip rendering the input form and disable the edit button. Closes #1798
|
LGTM 👍 |
edmundoa
added a commit
that referenced
this pull request
Feb 11, 2016
Do not render input form when type is not available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, the inputs page would break when the type definition for a
given input is not present (for example due to a plugin not being
loaded). Now we skip rendering the input form and disable the edit
button.
Closes #1798