-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple keyword time range validation from keyword time range preview in time range picker. #18879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d018da
to
63c9230
Compare
63c9230
to
0972600
Compare
0972600
to
be78a90
Compare
maxiadlovskii
approved these changes
Apr 24, 2024
linuspahl
added a commit
that referenced
this pull request
Apr 24, 2024
…w in time range picker. (#18879) * Consider user time zone for initial keyword time range. * Make sure to not disable submit button when chanign tabs. * Decouple keyword time range validation from keyword time range preview in time range picker. * Adding changelog. * Fixing test
linuspahl
added a commit
that referenced
this pull request
May 8, 2024
…w in time range picker. (#18879) * Consider user time zone for initial keyword time range. * Make sure to not disable submit button when chanign tabs. * Decouple keyword time range validation from keyword time range preview in time range picker. * Adding changelog. * Fixing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: This PR needs a backport to
6.0
Description
Motivation and Context
With this PR we are separating the time range validation from time range preview in time keyword tab of the range picker.
This approach has multiple advantages
validate
prop of the keyword formik field and have all the validation in the form validate functionvalidatingKeyword
state to disable the submit button while the keyword is being validatedThe main disadvantage:
This restructuring is fixing three bugs:
Fixes #18809