-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically generate datanode.conf.example #19141
Open
todvora
wants to merge
12
commits into
master
Choose a base branch
from
feature/automatic-datanode.conf.example
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
db97490
Automatically generate datanode.conf.example + csv documentation of c…
todvora 228862a
code cleanup, tests
todvora a8656ca
Merge branch 'master' into feature/automatic-datanode.conf.example
todvora 1b959c0
Merge branch 'master' into feature/automatic-datanode.conf.example
todvora fe6ce97
Merge branch 'master' into feature/automatic-datanode.conf.example
todvora c031465
Merge branch 'master' into feature/automatic-datanode.conf.example
todvora 4bf1ff6
add spaces around = in generated config example
todvora ffed46e
adjust spaces in generated config files, add tests for ordering
todvora dfc5cda
Merge branch 'master' into feature/automatic-datanode.conf.example
todvora 06022c4
Merge branch 'master' into feature/automatic-datanode.conf.example
todvora 5a1c5d2
Added support for sections - both on class level and field level
todvora 5bb4d85
Merge branch 'master' into feature/automatic-datanode.conf.example
moesterheld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think repeating the section headings and descriptions is not optimal. Maybe it would make sense to introduce an id to the sections which can be referenced (or reference by heading as it is and make description optional?)