Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-memory client cert storage used during cert signing #19180

Merged
merged 4 commits into from Apr 30, 2024

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Apr 26, 2024

We don't need any of those certificates stored on FS, they are just used during the signing process. For that, we can use an in-memory implementation.

/nocl

Motivation and Context

Fixes #18587

How Has This Been Tested?

Manually, as an integration test would need a fully secured datanode instead, which we so far can't provide in matrix tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora marked this pull request as ready for review April 29, 2024 07:35
@todvora todvora requested a review from janheise April 29, 2024 07:35
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for changing this. lgtm

@moesterheld moesterheld merged commit 4488057 into master Apr 30, 2024
5 checks passed
@moesterheld moesterheld deleted the fix/dont-store-client-certs-on-fs branch April 30, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't store generated one-shot client certificates
2 participants