Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop storing units in searches #19458

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

luk-kaminski
Copy link
Contributor

@luk-kaminski luk-kaminski commented May 27, 2024

Description

Stop storing units in searches.
It was decided they should be stored in views.
Effectively rolls back this one : #19307
/nocl

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@luk-kaminski luk-kaminski marked this pull request as ready for review May 27, 2024 12:30
@luk-kaminski luk-kaminski mentioned this pull request May 29, 2024
9 tasks
@janheise janheise merged commit 8c3f53e into master May 30, 2024
7 checks passed
@janheise janheise deleted the units/stop_storing_units_in_searches branch May 30, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants