Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing withStreams. #19631

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Removing withStreams. #19631

merged 6 commits into from
Jun 17, 2024

Conversation

dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jun 13, 2024

Description

Motivation and Context

This PR is removing the withStreams HOC and replaces it with usages of the StreamsContext.

The majority of the PR consists of typing improvements and migrations of components from untyped class components to typed functions.

/prd Graylog2/graylog-plugin-enterprise#7522
/nocl No user-facing change.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers requested review from linuspahl and a team June 14, 2024 06:17
@linuspahl linuspahl merged commit a36aa56 into master Jun 17, 2024
6 checks passed
@linuspahl linuspahl deleted the refactor/remove-with-streams branch June 17, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants