Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix change password form #2105

Merged
merged 3 commits into from Apr 19, 2016
Merged

Fix change password form #2105

merged 3 commits into from Apr 19, 2016

Conversation

edmundoa
Copy link
Contributor

This PR addresses a couple of issues with the edit password form:

  • Display the current (old) password input field when users edit their own profile]
  • Change the response on the change password method, returning a 400 when the old password was missing or wrong, instead of a 403
  • Improve error messages when there was an error updating the user or changing the password.

Fixes #2103

Edmundo Alvarez added 3 commits April 18, 2016 18:32
Show old password input when user edits their own account
9c4df8f 
Fix condition to display this field. Fixes #2103
Change server response when old password is wrong
6b09e50 
When users change their own password, return a 400 error if they did not
provide the current (old) password, or if it was incorrect.

Refs #2103
Improve displayed errors on user edit forms
bcb7101
@edmundoa edmundoa added this to the 2.0.0 milestone Apr 18, 2016
@bernd bernd self-assigned this Apr 19, 2016
@bernd
Copy link
Member

bernd commented Apr 19, 2016

LGTM 👍

@bernd bernd merged commit de0de72 into master Apr 19, 2016
@bernd bernd deleted the issue-2103 branch April 19, 2016 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bernd bernd

Labels
ready-for-review web
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edmundoa @bernd