New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve index rotation/retention upgrade documentation #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||
The old settings from the `graylog.conf` or `/etc/graylog/server/server.conf` will be migrated to the database. | ||
|
||
**WARNING:** When you upgrade from a 1.x version and you modified any rotation/retention settings, please make sure you **KEEP** your old settings in the config file so the migration process will add your old settings to the database! Otherwise the retention process will use the default settings and might remove a lot of indices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use the standard admonition WARNING:
here?
http://asciidoctor.org/docs/user-manual/#admonition
Updated after feedback. |
LGTM. 👍 |
dennisoelkers
added a commit
that referenced
this pull request
May 2, 2016
(cherry picked from commit 9d97be2) # # Last 5 commit messages # ---------------------- # a346e16 Improve index rotation/retention upgrade documentation (#2171) [Bernd Ahlers] # 5eb97e8 Return explicit session validation response instead of HTTP status (#2157) [Dennis Oelkers] # b714c0f Really use correct link to Users & Roles docs [Jochen Schalanda] # c82ff6f Use correct link to Users & Roles documentation [Jochen Schalanda] # ef19e14 Add '1.3' and '2.0' to Travis CI deploy branch list [Jochen Schalanda] # # ESLint output # -------------
dennisoelkers
added a commit
that referenced
this pull request
May 2, 2016
(cherry picked from commit 25a83cd) # # Last 5 commit messages # ---------------------- # ff7b9bb Fixing spacing for getting started error message. [Dennis Oelkers] # a346e16 Improve index rotation/retention upgrade documentation (#2171) [Bernd Ahlers] # 5eb97e8 Return explicit session validation response instead of HTTP status (#2157) [Dennis Oelkers] # b714c0f Really use correct link to Users & Roles docs [Jochen Schalanda] # c82ff6f Use correct link to Users & Roles documentation [Jochen Schalanda] # # ESLint output # -------------
bernd
added a commit
that referenced
this pull request
May 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure people keep their old settings so they will be migrated to the database.
Refs #2166
(I have a diff for master as well. Once this is merged I will commit it.)