Set Cache-Control on rest resources #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some browsers cache rest requests (like IE/Edge), so we need to set the Cache-Control header to no-cache to avoid caching issues. In order to only set cache headers into requests coming from browsers, we now set the X-Requested-With header in all our XHR requests.
|
LGTM. 👍 |
joschi
pushed a commit
that referenced
this pull request
May 17, 2016
Some browsers cache rest requests (like IE/Edge), so we need to set the "Cache-Control" header to no-cache to avoid caching issues. In order to only set cache headers into requests coming from browsers, we now set the X-Requested-With header in all our XHR requests. (cherry picked from commit 20c32a6)
|
It seems that these changes also have the added benefit of removing that annoying login popup window triggered in the login page by an Ajax request. |
|
Forget my last comment, that was already fixed in #2157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some browsers cache Ajax requests (like IE/Edge), so we need to set the
Cache-Controlheader tono-cacheto avoid caching issues.In order to only set cache headers into requests coming from browsers, we now set the
X-Requested-Withheader in all our XHR requests coming from the web interface.Fixes #2243.
This PR should also be merged into master.