Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use right metrics to display buffer usage #2300

Merged
merged 1 commit into from May 31, 2016
Merged

Use right metrics to display buffer usage #2300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 10 additions & 5 deletions graylog2-web-interface/src/components/nodes/BufferUsage.jsx
View file
Open in desktop
Expand Up @@ -22,30 +22,35 @@ const BufferUsage = React.createClass({
},
mixins: [Reflux.connect(MetricsStore)],
componentWillMount() {
const prefix = this._metricPrefix();
const metricNames = [
this._metricPrefix() + 'usage',
this._metricPrefix() + 'size',
`${prefix}.usage`,
`${prefix}.size`,
];
metricNames.forEach((metricName) => MetricsActions.add(this.props.nodeId, metricName));
},
_metricPrefix() {
return `org.graylog2.buffers.${this.props.bufferType}`;
},
_metricFilter() {
return `org\\.graylog2\\.buffers\\.${this.props.bufferType}\\.|${this.props.bufferType}buffer`;
},
render() {
if (!this.state.metrics) {
return <Spinner />;
}
const nodeId = this.props.nodeId;
const usageMetric = this.state.metrics[nodeId][this._metricPrefix() + 'usage'];
const prefix = this._metricPrefix();
const usageMetric = this.state.metrics[nodeId][`${prefix}.usage`];
const usage = usageMetric ? usageMetric.metric.value : NaN;
const sizeMetric = this.state.metrics[nodeId][this._metricPrefix() + 'size'];
const sizeMetric = this.state.metrics[nodeId][`${prefix}.size`];
const size = sizeMetric ? sizeMetric.metric.value : NaN;
const usagePercentage = (!isNaN(usage) && !isNaN(size) ? usage / size : 0);
const percentLabel = NumberUtils.formatPercentage(usagePercentage);

return (
<div>
<LinkContainer to={Routes.filtered_metrics(nodeId, this._metricPrefix())}>
<LinkContainer to={Routes.filtered_metrics(nodeId, this._metricFilter())}>
<Button bsSize="xsmall" className="pull-right">Metrics</Button>
</LinkContainer>
<h3>{this.props.title}</h3>
Expand Down