Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of "relativePath" for graylog-plugin-web-parent #2927

Merged
merged 1 commit into from Oct 12, 2016
Merged

Get rid of "relativePath" for graylog-plugin-web-parent #2927

merged 1 commit into from Oct 12, 2016

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Oct 6, 2016

Description

Move ./graylog-plugin-web-parent to ./graylog-plugin-parent/graylog-plugin-web-parent to get rid of the relativePath tag in the Maven POM of plugins (and thus the reliance on a specific directory layout).

Motivation and Context

The original author of the plugin parent POMs (hi! 👋) chose the flat directory layout for simplicity but ultimately failed to see the problems which would arise when breaking the Maven conventions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@joschi joschi added this to the 2.2.0 milestone Oct 6, 2016
@kroepke kroepke self-assigned this Oct 7, 2016
Copy link
Member

@kroepke kroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
In order to make graylog-project work for plugins in the future, we agreed on the following changes for plugins:

  • add relativePath to the parent section as appropriate to find the correct parent in a single reactor build
  • add Sonatype snapshot repository to each plugin to allow standalone build to succeed (e.g. those on TravisCI running the Java unit tests). Javascript build still requires the local checkout of the server source code.

@bernd bernd self-assigned this Oct 12, 2016
@bernd bernd merged commit 702e46f into Graylog2:master Oct 12, 2016
@joschi joschi deleted the graylog-plugin-parent branch October 12, 2016 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants