Fix field analyzers loading when search changes #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 27, 2016 16:26
Before this change we were using the current input values as search parameters, instead of using those used in the last executed search.
When a new search is executed, fetch new quick values and field statictics data. In this way the displayed information will be in sync with the search query, time range, and stream used in the message list and histogram. The field graphs were already updating when the search histogram changed, so they do not require further changes at this point. Fixes #2908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, quick values and field statistics analyzers didn't update when a new search was executed, something that was confusing, as described in #2908.
This PR makes those components to fetch new data when any search parameter changes, keeping the data in sync with the current search.
Field graphs do not require any changes, as they were already updating when the search histogram was refreshed.
Fixes #2908