Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast and loud for invalid GELF messages #3972

Merged
merged 5 commits into from Jul 5, 2017
Merged

Fail fast and loud for invalid GELF messages #3972

merged 5 commits into from Jul 5, 2017

Commits on Jul 3, 2017

  1. Fail fast and loud for invalid GELF messages

    Instead of waiting for a later stage and "silently" dropping (logged on DEBUG)
    invalid messages, `GelfCodec` now actively checks for the existence and validity
    of mandatory GELF message fields (such as "version", "host", "short_message", and
    "timestamp", according to the GELF spec).
    
    Refs http://docs.graylog.org/en/2.2/pages/gelf.html
    Fixes #3970
    Jochen Schalanda committed Jul 3, 2017
    Copy the full SHA
    1293a6e View commit details
    Browse the repository at this point in the history
  2. Don't check "version" field for backward-compatibility

    There are still many GELF client libraries out there using either "1.0" or
    no value at all for the GELF "version" field.
    Jochen Schalanda committed Jul 3, 2017
    Copy the full SHA
    ec26295 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2017

  1. Make GELF validation more lenient

    Jochen Schalanda committed Jul 5, 2017
    Copy the full SHA
    cb2597e View commit details
    Browse the repository at this point in the history
  2. Add test for minimal GELF messages

    Jochen Schalanda committed Jul 5, 2017
    Copy the full SHA
    4ca36de View commit details
    Browse the repository at this point in the history
  3. Fix logic for validating "host" message field

    Jochen Schalanda committed Jul 5, 2017
    Copy the full SHA
    7505d0b View commit details
    Browse the repository at this point in the history