Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Multi Search in Searches to prevent large HTTP request headers #4149

Merged
merged 1 commit into from Sep 20, 2017
Merged

Use Multi Search in Searches to prevent large HTTP request headers #4149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
34 changes: 14 additions & 20 deletions graylog2-server/src/main/java/org/graylog2/indexer/cluster/jest/JestUtils.java
View file
Open in desktop
Expand Up @@ -17,7 +17,6 @@
package org.graylog2.indexer.cluster.jest;

import com.fasterxml.jackson.databind.JsonNode;
import com.google.common.collect.ImmutableList;
import io.searchbox.action.Action;
import io.searchbox.client.JestClient;
import io.searchbox.client.JestResult;
Expand All @@ -29,10 +28,10 @@
import org.graylog2.indexer.QueryParsingException;

import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.function.Supplier;
import java.util.stream.Collectors;


public class JestUtils {
Expand Down Expand Up @@ -64,24 +63,29 @@ public static <T extends JestResult> T execute(JestClient client, Action<T> requ
}

public static ElasticsearchException specificException(Supplier<String> errorMessage, JsonNode errorNode) {
final List<JsonNode> rootCauses = extractRootCauses(errorNode);
final List<String> reasons = extractReasons(rootCauses);
final JsonNode rootCauses = errorNode.path("root_cause");
final List<String> reasons = new ArrayList<>(rootCauses.size());

for (JsonNode rootCause : rootCauses) {
final String type = rootCause.path("type").asText(null);
if (type == null) {
final JsonNode reason = rootCause.path("reason");
if (reason.isTextual()) {
reasons.add(reason.asText());
}

final JsonNode type = rootCause.path("type");
if (!type.isTextual()) {
continue;
}
switch(type) {
switch(type.asText()) {
case "query_parsing_exception":
return buildQueryParsingException(errorMessage, rootCause, reasons);
case "index_not_found_exception":
final String indexName = rootCause.path("resource.id").asText();
return buildIndexNotFoundException(errorMessage, indexName);
case "illegal_argument_exception":
final String reason = rootCause.path("reason").asText();
if (reason.startsWith("Expected numeric type on field")) {
return buildFieldTypeException(errorMessage, reason);
final String reasonText = reason.asText();
if (reasonText.startsWith("Expected numeric type on field")) {
return buildFieldTypeException(errorMessage, reasonText);
}
break;
}
Expand All @@ -98,16 +102,6 @@ private static FieldTypeException buildFieldTypeException(Supplier<String> error
return new FieldTypeException(errorMessage.get(), reason);
}

private static List<String> extractReasons(List<JsonNode> rootCauses) {
return rootCauses.stream()
.map(rootCause -> rootCause.path("reason").asText(null))
.collect(Collectors.toList());
}

private static List<JsonNode> extractRootCauses(JsonNode jsonObject) {
return ImmutableList.copyOf(jsonObject.path("root_cause").iterator());
}

private static QueryParsingException buildQueryParsingException(Supplier<String> errorMessage,
JsonNode rootCause,
List<String> reasons) {
Expand Down