New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify definition of `web_endpoint_uri` #5359

Merged
merged 2 commits into from Dec 5, 2018

Conversation

Projects
None yet
2 participants
@eightnoneone
Copy link

eightnoneone commented Dec 4, 2018

Definition provided in context of web endpoint is vague as REST is not clarified.

We spent way too long chasing rest_transport_uri and rest_listen_uri as solutions to what controlled what was promoted into the browser for REST calls. Searching "REST" in the config misses web_endpoint_uri.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Show resolved Hide resolved misc/graylog.conf Outdated

@dennisoelkers dennisoelkers merged commit 830fcfc into Graylog2:2.5 Dec 5, 2018

1 of 3 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 3074 has failed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 2383 has failed
Details
license/cla Contributor License Agreement is signed.
Details
@dennisoelkers

This comment has been minimized.

Copy link
Member

dennisoelkers commented Dec 5, 2018

Thanks for the contribution, @eightnoneone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment