Fix test depending on Graylog minor version. #5671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for the `AppErrorBoundary` was using a DOM snapshot containing verbatim HTML elements generated by the `ErrorPage` component including the current Graylog version. This was leading to a test failure after the minor version was bumped. This change is replacing the snapshot with test matchers checking for the existence of the `ErrorPage` component and the correctness of the props passed to it.
kmerz
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
The test for the
AppErrorBoundarywas using a DOM snapshot containingverbatim HTML elements generated by the
ErrorPagecomponent includingthe current Graylog version. This was leading to a test failure after
the minor version was bumped.
This change is replacing the snapshot with test matchers checking for
the existence of the
ErrorPagecomponent and the correctness of theprops passed to it.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: